feat: transaction notifications for incoming transactions - #1359
Draft
sneurlax wants to merge 3 commits into
Draft
feat: transaction notifications for incoming transactions#1359sneurlax wants to merge 3 commits into
sneurlax wants to merge 3 commits into
Conversation
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 19:00
sneurlax
force-pushed
the
feat/300-transaction-notifications
branch
from
August 20, 2026 21:27
4ffd667 to
92767b7
Compare
…navigator CryptoNotifications sat in home:, which makes it a route, so the first navigation after login disposed it. Nothing depended on it staying alive until incoming-transaction notifications started gating on hasListeners.
Fires an OS and in-app notification when an incoming transaction is first seen. Delivery is acknowledged by the listener so a failed or unlistened send is retried rather than recorded, and a txid is only marked delivered after it is durably persisted. Per-wallet state is namespaced into the prefs box because per-wallet Hive boxes are only opened for installs predating the Isar migration. Wallets that exist at upgrade time are marked initialized once so their history is not replayed as notifications; new wallets opt in explicitly and restores stay silent. The delivered ledger is capped at 256 entries per wallet, and confirmation watching is limited to ElectrumX wallets.
sneurlax
force-pushed
the
feat/300-transaction-notifications
branch
from
August 24, 2026 21:31
be49563 to
146d7a1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1359 +/- ##
===========================================
+ Coverage 4.79% 4.87% +0.07%
===========================================
Files 1109 1111 +2
Lines 111003 111109 +106
===========================================
+ Hits 5325 5416 +91
- Misses 105678 105693 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #300