Skip to content

Julian/various fixes contd - #1436

Closed
julian-CStack wants to merge 73 commits into
stagingfrom
julian/various-fixes-contd
Closed

Julian/various fixes contd#1436
julian-CStack wants to merge 73 commits into
stagingfrom
julian/various-fixes-contd

Conversation

@julian-CStack

Copy link
Copy Markdown
Collaborator

replaces and expands on #1432

# Conflicts:
#	pubspec.lock
#	scripts/app_config/templates/pubspec.template.yaml
- Explicit editable and canonical parsers, strict ASCII amount formatting, locale relocalization, and isolated IME recovery

- Wire existing formatters to their controllers
… fees. Validate it against base and priority fees, and use the same cap and gas limit for transaction construction and maximum-fee estimates.

- Localize custom fee input and reject malformed gas limits.
- parse scanned payment amounts canonically, preserve values across locale changes, validate nonce text, and keep displayed fees separate from editable controller text
…us rewrites, and locale changes. Parse exchange input through the shared editable layer while retaining the for-lack-of-a-better-option-currently existing 8 decimal policy
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.16720% with 1963 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.70%. Comparing base (da38ddc) to head (cbd7a3f).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
lib/pages/coin_control/coin_control_view.dart 0.00% 219 Missing ⚠️
.../coin_control/desktop_coin_control_use_dialog.dart 0.00% 134 Missing ⚠️
...eive_view/generate_receiving_uri_qr_code_view.dart 0.00% 114 Missing ⚠️
...ecific/coin_control/desktop_coin_control_view.dart 0.00% 101 Missing ⚠️
lib/pages/send_view/send_view.dart 0.00% 88 Missing ⚠️
...exchange_view/exchange_step_views/step_2_view.dart 0.00% 78 Missing ⚠️
lib/pages/send_view/sol_token_send_view.dart 4.87% 78 Missing ⚠️
...ific/desktop_exchange/desktop_all_trades_view.dart 2.53% 77 Missing ⚠️
...ange/exchange_steps/subwidgets/desktop_step_2.dart 0.00% 77 Missing ⚠️
...ew/wallet_view/sub_widgets/desktop_token_send.dart 2.59% 75 Missing ⚠️
... and 63 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1436      +/-   ##
===========================================
+ Coverage     4.79%    6.70%   +1.90%     
===========================================
  Files         1109     1116       +7     
  Lines       111003   111739     +736     
===========================================
+ Hits          5325     7487    +2162     
+ Misses      105678   104252    -1426     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sneurlax
sneurlax force-pushed the julian/various-fixes-contd branch from d59abed to 25c93da Compare August 28, 2026 03:12
Packages built through Flutter native assets (hook/build.dart) land in
build/native_assets/<os>/, which the old plugin-only install loop never
copies into bundle/lib. With flutter_mwebd moving to native assets the
Linux bundle silently omitted libmwebd.so. Flutter's own CMake migration
does not apply here because it edits the managed flutter/CMakeLists.txt,
so add the stock template's install(DIRECTORY) stanza to both templates.
@sneurlax sneurlax closed this Aug 28, 2026
@sneurlax
sneurlax deleted the julian/various-fixes-contd branch August 28, 2026 03:46
@sneurlax

Copy link
Copy Markdown
Member

eh my bad, just intended to reset state, not delete the branch and close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants