-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] modules.php : Modify the text to explain that Cypht supports JMAP (RFC8621) by default. #1277
base: master
Are you sure you want to change the base?
[UI] modules.php : Modify the text to explain that Cypht supports JMAP (RFC8621) by default. #1277
Conversation
1c37cd5
to
d1d141b
Compare
modules/nux/modules.php
Outdated
@@ -80,6 +81,9 @@ public function process() { | |||
if (data_source_available($modules, 'smtp')) { | |||
$smtp_servers = count(Hm_SMTP_List::dump(false)); | |||
} | |||
if (data_source_available($modules, 'jmap')) { | |||
$jmap_servers = count(Hm_IMAP_List::dump(false)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you will get imap servers too, i mean it will combine imap ad jmap. If soo then we don't need to add an other link for jmap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the first idea it was already well started, it was rather necessary to apply the filter here: https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L64 without forgetting in this case to do it for this too: https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L75
d1d141b
to
540324e
Compare
540324e
to
bb9ada1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change and we are done. Make sure you rebase too to make selenium test working
@@ -592,12 +597,12 @@ protected function output() { | |||
$res .= sprintf(' <a href="?page=servers#%s_section">%s</a>', $proto, $this->trans('Add')); | |||
} | |||
else { | |||
if ($server_data[$proto] > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need this if check to support the s for exemple source and sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already resolved here ($server_data[$proto] > 1 ? 'sources' : 'source') and here ($server_data[$proto] > 1 ? 'sources' : 'source').
…P (RFC8621) by default.
bb9ada1
to
a3ef235
Compare
Related task
Modify the text in the help section to explain that Cypht supports the JMAP (RFC8621) protocol in addition to IMAP and SMTP, and make JMAP available by default in standalone Cypht installations or those integrated with Tiki.