[UI] modules.php : Modify the text to explain that Cypht supports JMAP (RFC8621) by default.

[Bienvenumoringa]

Related task

Modify the text in the help section to explain that Cypht supports the JMAP (RFC8621) protocol in addition to IMAP and SMTP, and make JMAP available by default in standalone Cypht installations or those integrated with Tiki.

[Shadow243]

Here you will get imap servers too, i mean it will combine imap ad jmap. If soo then we don't need to add an other link for jmap.

[Shadow243]

With the first idea it was already well started, it was rather necessary to apply the filter here: https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L64 without forgetting in this case to do it for this too: https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L75

[Shadow243]

You don't need to repeat it after SMTP. it's already okay after IMAP as it's an imap alternative, like this:

you can use a cndition like this:

$res .= sprintf(
                        $this->trans('You have %d %s%s'),
                        $server_data[$proto],
                        mb_strtoupper($proto_dsp),
                        ($proto === 'imap' ? ' / JMAP ' . $server_data['jmap'] . ($server_data[$proto] > 1 ? ' sources' : ' source') : ($server_data[$proto] > 1 ? ' sources' : ' source'))
                    );

and filter from here:

if (data_source_available($modules, 'imap')) {
            $imap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return !array_key_exists('type', $v);}));
            $jmap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return array_key_exists('type', $v) && $v['type'] == 'jmap'; }));
        }

$this->out('nux_server_setup', array(
            'imap' => $imap_servers,
            'jmap' => $jmap_servers,
            'feeds' => $feed_servers,
            'smtp' => $smtp_servers,
            'profiles' => $profiles
        ));

[Bienvenumoringa]

You don't need to repeat it after SMTP. it's already okay after IMAP as it's an` imap` alternative, like this:

you can use a cndition like this:

$res .= sprintf(
                        $this->trans('You have %d %s%s'),
                        $server_data[$proto],
                        mb_strtoupper($proto_dsp),
                        ($proto === 'imap' ? ' / JMAP ' . $server_data['jmap'] . ($server_data[$proto] > 1 ? ' sources' : ' source') : ($server_data[$proto] > 1 ? ' sources' : ' source'))
                    );

and filter from here:

if (data_source_available($modules, 'imap')) {
            $imap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return !array_key_exists('type', $v);}));
            $jmap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return array_key_exists('type', $v) && $v['type'] == 'jmap'; }));
        }

$this->out('nux_server_setup', array(
            'imap' => $imap_servers,
            'jmap' => $jmap_servers,
            'feeds' => $feed_servers,
            'smtp' => $smtp_servers,
            'profiles' => $profiles
        ));

apply changers

[Shadow243]

One more change and we are done. Make sure you rebase too to make selenium test working

[Shadow243]

You will need this if check to support the s for exemple source and sources

[Bienvenumoringa]

It is already resolved here ($server_data[$proto] > 1 ? 'sources' : 'source') and here ($server_data[$proto] > 1 ? 'sources' : 'source').