Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Json Engine to be less dependency heavy. #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ryanbartley
Copy link

Fix for #5.

  • Updated Json Engine throughout to JsonCpp to loosen dependence tree.
  • Updated CMake for OSX and Linux.
  • Still needs update for Windows Visual Studio project.

@jtyjty99999
Copy link

jtyjty99999 commented Sep 1, 2016

@ryanbartley hi , I use your fork under mac os, and compiled , when after cmake .., i type in make, then It has two error below:

`
[ 72%] Building CXX object IO-glTF/CMakeFiles/IO-glTF.dir/gltfWriter-Texture.cpp.o

[ 75%] Building CXX object IO-glTF/CMakeFiles/IO-glTF.dir/gltfWriter.cpp.o

/Users/adams/Documents/code/FBX-glTF/IO-glTF/gltfWriter.cpp:433:20: error:

  cannot increment value of type 'std::initializer_list<int>'

                            sIdentity4Mat[i++] = val;

                                          ~^

/Users/adams/Documents/code/FBX-glTF/IO-glTF/gltfWriter.cpp:597:8: error:

  cannot increment value of type 'std::initializer_list<int>'

                    ar[k++] = ((r [i] [j])) ;

                       ~^

2 errors generated.

make[2]: *** [IO-glTF/CMakeFiles/IO-glTF.dir/gltfWriter.cpp.o] Error 1

make[1]: *** [IO-glTF/CMakeFiles/IO-glTF.dir/all] Error 2

make: *** [all] Error 2`

I'm not family with c++, do you know how to solve this problem?

@jbaicoianu
Copy link

I had problems compiling due to the Casablanca dependency, this patch applied cleanly and I was able to convert a model with it. +1 for this patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants