Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day-of-month with ordinal suffix. #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mbostock
Copy link
Member

This implementation is limited to ordinal as a suffix, so it won’t support ordinal indicators as prefixes.

TODO

  • Pick a directive (%o).
  • Format ordinal day-of-month in en-US locale.
  • Format ordinal day-of-month in other locales?
  • Allow the ordinal to be a prefix instead of a suffix, such as for Chinese?
  • Decide how to parse ordinal day-of-month?
  • It’s icky that the locale now contains code rather than being strictly declarative.
  • Is there a better way to reuse logic across locales?

@mbostock
Copy link
Member Author

It appears the strftime npm package uses %o for ordinal day-of-month, too. Yay.

@Fil Fil mentioned this pull request Jun 5, 2020
6 tasks
@Fil Fil added the feature label Jul 10, 2020
@raags
Copy link

raags commented Mar 11, 2022

Any reason why this hasn't been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants