Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all remaining references of Guava's Files class. #7278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LukasMansour
Copy link
Member

Motivation:
Closes #3808

Modification:
Removes the last instances of com.google.common.io.Files and replaces most of them with the JDK alternative. (Also required updating one or two guava classes, like the TreeTraverser)

Result:
The remaining references of Guava's Files class are removed and some small tweaks to reduce the usage of Guava were done.

Signed-off-by: Lukas Mansour lukas.mansour@desy.de

@LukasMansour LukasMansour marked this pull request as ready for review September 13, 2023 12:15
if (file.isDirectory()) {
File[] files = file.listFiles();
if (files != null) {
return Ordering.natural().sortedCopy(asList(files));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be de-guavaed as well

Copy link
Member

@kofemann kofemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace guava's com.google.common.io.Files implementation with analog from jdk7
2 participants