fix: prevent console-setup from blocking first boot - #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ubuntu ISO installations can stall on first boot at:
The Ubuntu 24.04.3 base contains
console-setup1.226ubuntu1. Whennoble-updatesupgrades it to 1.226ubuntu1.1, package configuration can fail during the ISO late-command. The prerequisite script previously hid that dpkg failure behindtee. On first boot,apt-get install -y kbdresumes the half-configured package and debconf opens a hiddenwhiptaildialog on/dev/pts/0. This leaves.firstbootin place and prevents any core containers from being created.This PR:
apt-getexit statuses while logging host updates and aborts on upgrade failure;kbdinstallation explicitly noninteractive.Type of change
How Has This Been Tested?
I reproduced the original failure with a complete KVM/UEFI install from a repo-generated Ubuntu 24.04.3 DAppNode ISO. At timeout,
.firstbootremained, all eleven core images were loaded,docker ps -awas empty, and the process tree ended in a hiddenconsole-setupwhiptail prompt.Focused validation after the change:
bash -n scripts/dappnode_install.sh scripts/dappnode_install_pre.shhost_updatechecks proving update and upgrade failures retain their original nonzero statuskbdandconsole-setup1.226ubuntu1.1 withDEBIAN_FRONTEND=noninteractive; package configuration completed anddpkg --auditwas cleanAn updated ISO was not rebuilt for this PR; the full VM run was used to establish the failing path, followed by focused validation of the fix.
Test Configuration:
Checklist
Why this surfaced now
This is a latent installer bug exposed by a recent Ubuntu archive update, rather than a recent change to the DAppNode first-boot code. The Ubuntu 24.04.3 ISO contains
console-setup1.226ubuntu1, whilenoble-updatesnow provides 1.226ubuntu1.1. Previously there was no newerconsole-setuppackage to configure, so the vulnerable path was effectively a no-op.Now the prerequisite host upgrade attempts that package transition during the unattended ISO late-command. Package configuration fails because debconf cannot ask questions there, but the
apt-get ... | teepipeline hides the failure. On first boot,apt-get install -y kbdretries the half-configured package and debconf starts a hiddenwhiptailprompt on/dev/pts/0. The installer remains atSetting up console-setup,.firstbootis never removed, and core container creation is skipped.The Ubuntu update is a no-change rebuild; the issue is not an intentional new prompt in the package. Reconfiguring the newly available version exposed the installer's existing noninteractive and error-propagation gaps.