Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

meesrutten
Copy link

Add Framer Motion implementation.

Let me know if anything needs to change!

@meesrutten meesrutten requested a review from a team as a code owner August 8, 2024 12:13
Copy link

vercel bot commented Aug 8, 2024

@meesrutten is attempting to deploy a commit to the darkroom Team on Vercel.

A member of the Team first needs to authorize it.

@clementroche
Copy link
Member

clementroche commented Aug 8, 2024

Thank you for this PR. However i think that this example should use lenis/react.

@feledori
Copy link
Contributor

feledori commented Aug 8, 2024

Agree with @clementroche, as most people using lenis with react will use lenis/react. React lenis will setup a rAF for itself so it has to be explicitly disabled with the autoRaf prop on the Provider. This is currently a discrepancy between lenis core and lenis react.

@clementroche
Copy link
Member

I'll probably wait until we find a proper solution about rAFs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants