Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panasonic DC-S5M2 support (data only) #427

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Feb 14, 2023

Partly addresses darktable-org/darktable#13511 and darktable-org/darktable#15446

Used ADC 15.2. Crop is unverified.

This depends on v8 decoder working.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (13a3318) to head (55a242d).
Report is 169 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    60.91%   60.91%           
========================================
  Files          271      271           
  Lines        16366    16366           
  Branches      2077     2077           
========================================
  Hits          9969     9969           
  Misses        6268     6268           
  Partials       129      129           
Flag Coverage Δ
benchmarks 11.84% <ø> (ø)
integration 45.05% <ø> (ø)
linux 57.10% <ø> (ø)
macOS 25.16% <ø> (ø)
rpu_u 45.05% <ø> (ø)
unittests 21.52% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos
Copy link
Contributor Author

kmilos commented Apr 18, 2023

Adding DC-S5M2X as alias (for testing? could/should be separated later?) - it's the same camera w/ additional FW capabilities: https://www.dpreview.com/reviews/panasonic-lumix-dc-s5-ii-dc-s5-iix-initial-review

Also verified the profile is the same in latest ADC 15.3 addition.

@kmilos
Copy link
Contributor Author

kmilos commented Sep 18, 2023

Adding DC-S5M2X as alias (for testing? could/should be separated later?)

I have now separated DC-S5M2X as an independent model. More samples have been uploaded.

@LebedevRI
Copy link
Member

Verified the samples.
I suppose someone could try porting the v8 decoder from RT/libraw.

@kmilos
Copy link
Contributor Author

kmilos commented Sep 18, 2023

I suppose someone could try porting the v8 decoder from RT/libraw.

Yes please @jdneumeyer77 😉

It's not public yet though AFAIK...

@jdneumeyer77
Copy link
Contributor

@kmilos Happy to port it once it's publicly available. I don't own the GH6, S5ii or S5ii-x. So I'll use the samples.

@LebedevRI
Copy link
Member

@jdneumeyer77 yes, please.

@kmilos
Copy link
Contributor Author

kmilos commented Feb 22, 2024

yes, please.

Still no public reference code available AFAIK 😞 (CC @mlouielu)

@LebedevRI
Copy link
Member

cough adobe dng converter cough Ghidra cough

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (13a3318) to head (55a242d).
Report is 218 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    60.91%   60.91%           
========================================
  Files          271      271           
  Lines        16366    16366           
  Branches      2077     2077           
========================================
  Hits          9969     9969           
  Misses        6268     6268           
  Partials       129      129           
Flag Coverage Δ
benchmarks 11.84% <ø> (ø)
integration 45.05% <ø> (ø)
linux 57.10% <ø> (ø)
macOS 25.16% <ø> (ø)
rpu_u 45.05% <ø> (ø)
unittests 21.52% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Requires New Raw Format Support
Development

Successfully merging this pull request may close these issues.

4 participants