fix(HttpConfig): Remove the optional argument to the default ctor

Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added. Closes #1285
dart-archive · Aug 1, 2014 · 9810c9b · 9810c9b
1 parent 879772f
commit 9810c9b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/lib/core_dom/http.dart b/lib/core_dom/http.dart
@@ -755,5 +755,7 @@ class Http {
 class HttpConfig {
   final Duration coalesceDuration;
 
-  HttpConfig({this.coalesceDuration});
+  HttpConfig(): coalesceDuration = null;
+
+  HttpConfig.withOptions({this.coalesceDuration});
 }
diff --git a/lib/core_dom/module_internal.dart b/lib/core_dom/module_internal.dart
@@ -86,7 +86,7 @@ class CoreDomModule extends Module {
     bind(HttpDefaultHeaders);
     bind(HttpDefaults);
     bind(HttpInterceptors);
-    bind(HttpConfig, toValue: new HttpConfig());
+    bind(HttpConfig);
     bind(Animate);
     bind(ViewCache);
     bind(BrowserCookies);

diff --git a/test/core_dom/http_spec.dart b/test/core_dom/http_spec.dart
@@ -1426,8 +1426,8 @@ void main() {
 
     describe('coalesce', () {
       beforeEachModule((Module module) {
-        var coalesceDuration = new Duration(milliseconds: 100);
-        module.bind(HttpConfig, toValue: new HttpConfig(coalesceDuration: coalesceDuration));
+        var duration = new Duration(milliseconds: 100);
+        module.bind(HttpConfig, toValue: new HttpConfig.withOptions(coalesceDuration: duration));
       });
 
       it('should coalesce requests', async((Http http) {