Skip to content

Commit

Permalink
Move 'make sure dynamic windows are enabled` define into .c file
Browse files Browse the repository at this point in the history
The `DART_MPI_ENABLE_DYNAMIC_WINDOWS` is only used inside the .c file,
so why adding the fallback into the .h file. Worth, the header is
installed and used by the header-lib part of DASH
`dash/include/dash/iterator/internal/GlobPtrBase.h`. Thus it gives the
impression, that you could change the value of
`DART_MPI_ENABLE_DYNAMIC_WINDOWS` after the installation of DASH.
  • Loading branch information
bertwesarg committed Jan 31, 2020
1 parent d72dfc5 commit babaa18
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 0 additions & 6 deletions dart-if/include/dash/dart/if/dart_globmem.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@
#include <dash/dart/if/dart_types.h>
#include <dash/dart/if/dart_team_group.h>

// make sure dynamic windows are enabled if shared windows are not disabled
#if !defined(DART_MPI_DISABLE_SHARED_WINDOWS) && \
!defined(DART_MPI_ENABLE_DYNAMIC_WINDOWS)
#define DART_MPI_ENABLE_DYNAMIC_WINDOWS
#endif

#ifdef __cplusplus
extern "C" {
#endif
Expand Down
6 changes: 6 additions & 0 deletions dart-impl/mpi/src/dart_globmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@
#define __STDC_FORMAT_MACROS
#include <inttypes.h>

// make sure dynamic windows are enabled if shared windows are not disabled
#if !defined(DART_MPI_DISABLE_SHARED_WINDOWS) && \
!defined(DART_MPI_ENABLE_DYNAMIC_WINDOWS)
#define DART_MPI_ENABLE_DYNAMIC_WINDOWS
#endif

/**
* TODO: add this window to the team_data for DART_TEAM_ALL as segment 0.
*/
Expand Down

0 comments on commit babaa18

Please sign in to comment.