Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest keycloak and AWS SDKs #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

james-callahan
Copy link

@james-callahan james-callahan commented Apr 3, 2023

The only error when building was that the signature of send() swapped the UserModel for just a string of the address

@james-callahan
Copy link
Author

@dasniko would you consider merging this?

@martinsotirov
Copy link

@dasniko I'd be interested in that too. Also the current Keycloak version is now 22.0.1, so the PR might need to be updated again before merged.

@james-callahan
Copy link
Author

the PR might need to be updated again before merged.

I'm happy to update it if it's going to get merged shortly.
But otherwise I'd end up bumping it perpetually.

@mirko-pira
Copy link

mirko-pira commented Aug 25, 2023

@dasniko I'd be interested in that too. Also the current Keycloak version is now 22.0.1, so the PR might need to be updated again before merged.

For 22.0.1:

deprecated:
javax.mail.internet.InternetAddress

new:
jakarta.mail.internet.InternetAddress

@james-callahan
Copy link
Author

@mirko-pira done.

@martinsotirov I have bumped keycloak now because of the InternetAddress deprecation.

@dasniko
Copy link
Owner

dasniko commented Aug 29, 2023

Hi @james-callahan
Thanks for your efforts and the PR. As you might have noticed, I don't actively maintain this repository any more, but I will be happy to merge your updates.
For a complete update PR, IMO also the README.md should be updated to reflect the current configuration possibilities. The current README still describes Wildfly configuration, but this is no more valid, as Wildfly is gone. If you are able to adjust also the README, please include an updated version to this PR.
Thanks.

@arnab2001
Copy link

@james-callahan really looking forward to an updated docs , thanks for your effort

@afgarcia86
Copy link

I would also greatly appreciate some documentation. I am struggling to understand how to enable this SPI.

@afgarcia86
Copy link

Ok I figured it out, I had to set --spi-email-sender-provider=aws-ses as a build arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants