Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Update numpy-dev-xfails.txt #171

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Aug 1, 2024

Hi @asmeurer,

I think that numpy-dev-xfails.txt file is outdated. For some test I see in logs:

/home/runner/work/array-api-compat/array-api-compat/array-api-tests/conftest.py:262: UserWarning: 19 ids in xfails file don't match any collected tests: 

@mtsokol
Copy link
Contributor Author

mtsokol commented Aug 1, 2024

Should other NumPy files also be updated?

array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(x1_i is -infinity and isfinite(x2_i) and x2_i > 0) -> -infinity]
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(x1_i is -infinity and isfinite(x2_i) and x2_i < 0) -> +infinity]
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i > 0 and x2_i is -infinity) -> -0]
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i < 0 and x2_i is +infinity) -> -0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I wonder what happened to these tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, these must be some of the special cases whose parsing is broken data-apis/array-api-tests#284.

@asmeurer asmeurer merged commit f3145b0 into data-apis:main Aug 7, 2024
39 checks passed
@mtsokol mtsokol deleted the update-numpy-dev-xfails branch August 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants