Use conj_physical for torch.conj #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch.conj sets the conjugation bit, which breaks other libraries. Fixes data-apis#173.
rgommers
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Looks good modulo the failure. The more principled fix would be to call torch.resolve_conj only in the interop functions between libraries, however there is no way to wrap __dlpack__ & co, so in practice this isn't doable from outside PyTorch.
The performance loss will be quite limited and specific to a few operations that PyTorch would otherwise be able to keep lazy, and isn't too much of a concern here I'd say.
| @@ -145,6 +145,9 @@ def can_cast(from_: Union[Dtype, array], to: Dtype, /) -> bool: | |||
| # Basic renames | |||
| bitwise_invert = torch.bitwise_not | |||
| newaxis = None | |||
| # torch.conj sets the conjugation bit, which breaks conversion to other | |||
| # libraries. See https://github.com/data-apis/array-api-compat/issues/173 | |||
| conj = torch.conj_physical | |||
There was a problem hiding this comment.
This fails a test for function names. It probably requires def conj(..):` instead? Either that, or special-casing in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.conj sets the conjugation bit, which breaks other libraries.
Fixes #173.