Update the api_version check to allow 2022.12 and warn on 2021.12 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if a warning is the best option here. The returned namespace is 2022.12 compliant, and that is also 2021.12 compliant (except for a few minor things). I don't think it's worth trying to support both, unless someone has a real use-case.
|
I'd leave out the warning and just return the superset of 2022.12 |
betatim
reviewed
Feb 9, 2024
| if api_version == '2021.12': | ||
| warnings.warn("The 2021.12 version of the array API specification was requested but the returned namespace is actually version 2022.12") | ||
| if api_version is not None and api_version != '2022.12': | ||
| raise ValueError("Only the 2022.12 version of the array API specification is currently supported") |
There was a problem hiding this comment.
The text of the error isn't right, no? Because 2022.12 and 2021.12 are supported
Can we somehow re-do the if statements? I think something like the below would be easier to read and implement the behaviour Ralf suggested (no warning, just return subset)
if api_version is not in ('2021.12', '2022.12', None):
raise ValueError(f"The specified Array API version '{api_version}' is not supported.")WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if a warning is the best option here. The returned namespace is 2022.12 compliant, and that is also 2021.12 compliant (except for a few minor things). I don't think it's worth trying to support both, unless someone has a real use-case.