Skip to content

Fix test failure if no device parameter #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prady0t wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −1
Open

Fix test failure if no device parameter #459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d1fe1b
Fix test failure if no device parameter
prady0t Aug 20, 2026
e7b5599
use another try block
prady0t Aug 20, 2026
104d104
better comment
prady0t Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion array_api_tests/dtype_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,11 @@ def is_device_dlpack_compatible(device):
"""If device is dlpack compatible, return True, else False"""
# XXX: there seems to be no better way than try-catch for __dlpack_device__()

x = xp.empty(2, device=device)
try:
x = xp.empty(2, device=device)
Comment thread
prady0t marked this conversation as resolved.
except:

@betatim betatim Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make this except TypeError (I think this is the exception?) to make sure we only catch errors that are due to the fact that there is no device keyword argument.

Even better would be having a way to inspect the array library/function to determine if there is a device argument or not. This would be explicitly checking what we want to know

# also covers libraries that does not support device parameter

@betatim betatim Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# also covers libraries that does not support device parameter
# also covers libraries that do not support device parameter

x = xp.empty(2)
try:
x.__dlpack_device__()
except:
Expand Down
Loading