Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that comparisons between columns from different dataframes is outside the standard #298

Closed

Conversation

MarcoGorelli
Copy link
Contributor

This has come up a few times

#249 (comment)

Are folks open to simply saying that the operation is undefined by the existing standard? Implementations can choose to raise

#287 (comment)

On way to do [Column.mean() whilst not having to materialise more times than necessary when filtering] is for the column to keep track of its originating DataFrame:


so let's document that it's outside the standard?

@rgommers
Copy link
Member

Thanks Marco. This PR is useful in identifying all (?) the potentially problematic methods and operator support. It makes it more concrete where we have tension between current eager and lazy libraries.

Are folks open to simply saying that the operation is undefined by the existing standard? Implementations can choose to raise

I'm not sure this is actually a good way to go. I'd like to explore a little more if we really can't do better than this, because it's at best unsatisfactory - as commented on in #249.

@MarcoGorelli
Copy link
Contributor Author

It's not just eager-vs-lazy, but also that eager libraries arguably shouldn't be doing more passes through their data then they need to #287 (comment)

@MarcoGorelli
Copy link
Contributor Author

From today's call: Columns may have an "owner" DataFrame, need to define expectations around how they behave (e.g. same owner, different owners, no owner)

@MarcoGorelli
Copy link
Contributor Author

From today's call: Columns may have an "owner" DataFrame, need to define expectations around how they behave (e.g. same owner, different owners, no owner)

taken forwards in #310

@MarcoGorelli MarcoGorelli reopened this Nov 7, 2023
@MarcoGorelli
Copy link
Contributor Author

reopening as maybe this is an alternative, see #310 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants