remove dtype from to_array #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
remove-dtype-from-to-array
branch
from
0d299aa
to
1970171
Compare
kkraus14
reviewed
Nov 17, 2023
Comment on lines
924
to
925
| and multiple columns' dtypes are combined according to the Array API's | ||
| type promotion rules. |
There was a problem hiding this comment.
Maybe link off to the type promotion rules? https://data-apis.org/array-api/latest/API_specification/type_promotion.html
Also, they don't define rules for mixed integer and floating-point types and specify it as implementation defined. Are we good with that as well?
There was a problem hiding this comment.
good call, have added
yeah that sounds fine to me, you OK with it too?
MarcoGorelli
added
API design
ergonomics
kkraus14
approved these changes
Nov 23, 2023
Comment on lines
834
to
835
| and multiple columns' dtypes are combined according to the Array API's | ||
| type promotion rules. |
There was a problem hiding this comment.
Did we want to link to the array API docs on these type promotion rules?
There was a problem hiding this comment.
sorry, forgot to push, have done so now
…dataframe-api into remove-dtype-from-to-array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #293