Use SetPermissions instead of UpdatePermissions when setting folder permissions based on top-level ones #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Oct 10, 2024
pietern
reviewed
Oct 10, 2024
lennartkats-db
previously requested changes
Oct 11, 2024
bundle/permissions/workspace_root.go
Outdated
| rootPath += "/" | ||
| } | ||
|
|
||
| if !strings.HasPrefix(b.Config.Workspace.ArtifactPath, rootPath) { |
There was a problem hiding this comment.
Artifacts in /Volumes/ should get special treatment. But for this PR I'd just make sure that it doesn't fail for Volumes.
For followup considerations: Volumes rely on grants, not permissions. And they lack fine-grained permissions. Plus users often won't have permissions to change grants. But what we may be able to do is check if the grants are correct. Doing so might be the job for a "top-level grants" feature though, rather than the "top-level permissions" feature.
cc @pietern
pietern
reviewed
Oct 24, 2024
andrewnester
force-pushed
the
fix/update-to-set-permissions
branch
from
c45c441
to
16f02c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed to use SetPermissions() to configure the permissions which remove other permissions on deployment folders.
Tests
Added unit test