-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SetPermissions instead of UpdatePermissions when setting folder permissions based on top-level ones #1822
base: main
Are you sure you want to change the base?
Conversation
bundle/permissions/workspace_root.go
Outdated
rootPath += "/" | ||
} | ||
|
||
if !strings.HasPrefix(b.Config.Workspace.ArtifactPath, rootPath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Artifacts in /Volumes/
should get special treatment. But for this PR I'd just make sure that it doesn't fail for Volumes.
For followup considerations: Volumes rely on grants, not permissions. And they lack fine-grained permissions. Plus users often won't have permissions to change grants. But what we may be able to do is check if the grants are correct. Doing so might be the job for a "top-level grants" feature though, rather than the "top-level permissions" feature.
cc @pietern
c45c441
to
16f02c0
Compare
Changes
Changed to use SetPermissions() to configure the permissions which remove other permissions on deployment folders.
Tests
Added unit test