-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape and subtitute query arguments client side #100
base: main
Are you sure you want to change the base?
Conversation
This commit ports approximately what the Python Databricks library does in order to handle query arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we explicitly did not add support for this. The feature is under development in spark and databricks. We'll add support for the driver once the backend is ready.
Got it, @andrefurlan-db . Is there an expected timeline for that development? I'm sure there's a lot in flight, just curious how far along that is. |
I did a bit of digging and it seems the parametrized query feature has been released in Spark 3.4.0 (merged since December 2022). However, it is not exposed in the thrift server which is used by databricks-sql-go to connect to Spark. To me it looks like the feature is ready but not exposed to external clients. |
Hi @nohajc! The library got a support for named query parameters since v1.5.0. Can you please try it and let us know if it works for you? Thanks! |
Hi, thank you for the information. I noticed the support has been added but I'm not using databricks at the moment. When I come back to it at some point, I will definitely try. Cheers! |
Coming from other Go database drivers the lack of query argument support was a surprise. This commit ports approximately what the Python Databricks library does in order to handle query arguments.
Feedback, suggestions, etc welcome!