[PECO-1431] Support Databricks OAuth in Azure #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyhu-db
requested review from
arikfr,
superdupershant,
yunbodeng-db,
kravets-levko,
susodapop,
nithinkdb,
andrefurlan-db and
rcypher-databricks
as code owners
jackyhu-db
changed the title
|
@jackyhu-db Is this related to databricks/databricks-sql-python#327 ? |
rcypher-databricks
approved these changes
Jan 25, 2024
@kravets-levko no, it is to support Databrick native OAuth in Azure, the other PR does not cover this. |
Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
jackyhu-db
changed the title
Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
jackyhu-db
commented
Jan 29, 2024
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
This comment was marked as resolved.
This comment was marked as resolved.
kravets-levko
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional property
useDatabricksOAuthInAzurein the parameterConnectionOptionsofDBSQLClient.connect.If it is set as
true, it will use Databricks native OAuth rather than Azure AD OAuth in both OAuth U2M and M2M flow. If it is not set or set asfalse, it will still use the existing Azure AD OAuth.To use this in OAuth M2M flow, the
oauthClientIdandoauthClientSecretin theConnectionOptionsmust be Databricks service principal client ID and secret which can be created by Databricks API or Databricks Account UI.