Don't truncate BigInts #268
Open
+2
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigInts are currently converted to JS Numbers, which can't fit values over 2**53. Fixes databricks#259
gabegorelick
requested review from
superdupershant,
yunbodeng-db,
kravets-levko,
andrefurlan-db,
rcypher-databricks,
jackyhu-db and
benc-db
as code owners
Comment on lines
-55
to
-57
| if (value instanceof Int64) { | ||
| return value.toNumber(); | ||
| } |
There was a problem hiding this comment.
Actually, these lines has to be kept, but instead of converting Int64 to Number it has to be converted to BigInt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigInts are currently converted to JS Numbers, which can't fit values over 2**53.
Fixes #259
This is a breaking change, and I don't expect this to be merged as-is (it might make sense to make this change in behavior opt in for now). But hopefully this can spur discussion.