Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resultFormat field to properly process query results #92

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Nov 8, 2022

getResultSetMetadata has a resultFormat field that should be used to determine a format of query result. Previously we alway tried to process results as COLUMN_BASED_SET, but here are few reasons to finally use that field:

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Base: 93.25% // Head: 93.80% // Increases project coverage by +0.54% 🎉

Coverage data is based on head (47592c8) compared to base (e57e017).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   93.25%   93.80%   +0.54%     
==========================================
  Files          51       49       -2     
  Lines         712      710       -2     
  Branches      101      100       -1     
==========================================
+ Hits          664      666       +2     
+ Misses         22       20       -2     
+ Partials       26       24       -2     
Impacted Files Coverage Δ
lib/DBSQLClient.ts 97.01% <ø> (ø)
lib/DBSQLOperation/SchemaHelper.ts 100.00% <100.00%> (ø)
lib/DBSQLOperation/index.ts 85.41% <100.00%> (-0.30%) ⬇️
lib/result/JsonResult.ts 82.97% <100.00%> (+7.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kravets-levko kravets-levko merged commit c99dfd1 into main Nov 9, 2022
@kravets-levko kravets-levko deleted the detect-result-type branch November 9, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants