-
Notifications
You must be signed in to change notification settings - Fork 95
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for table comments (#308)
* Add support for table comments Signed-off-by: Christophe Bornet <cbornet@hotmail.com> * Use per-table DTE to get the table comments Signed-off-by: Christophe Bornet <cbornet@hotmail.com> * Revert pytest.ini change Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Fix typo in test name for columns. Move .engine and .compile into a base class. Scaffold in the Table Comment unit tests. Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Add unit tests for table comments Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Revert overrides since these aren't needed after #328 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Stop skipping table comment portions of ComponentReflectionTest Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Move DTE parsing into _parse.py Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Add e2e test using inspector Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Add unit test for new method in _parse.py Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Fix assertion in column comment test This was missed in #328 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> --------- Signed-off-by: Christophe Bornet <cbornet@hotmail.com> Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> Co-authored-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
- Loading branch information
Showing
8 changed files
with
174 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.