[Issue 115] sqlalchemy: fix has_table so it honours schema= argument #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
has_table
method was badly implemented because it didn't honour the providedschema=
argument. I've updated the method and added an integration test. I also added acatalog=
argument so users can runhas_table
across catalogs in UC-land.Related Tickets & Documents
Closes #115
This change is branched off of #173 so there appears to be more happening than is necessary. You only need to review the last two commits.I rebased off ofmain
so now there is a sensible number of commits.