[Issue 115] sqlalchemy: fix has_table so it honours schema= argument #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
|
I've confirmed this passes all sqlalchemy e2e tests on version 1.3.24 and 1.4.48 
|
added 4 commits
July 11, 2023 20:04
Closes #115 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
rcypher-databricks
approved these changes
Jul 12, 2023
mattdeekay
approved these changes
Jul 12, 2023
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
|
Synced with |
susodapop
pushed a commit
to unj1m/databricks-sql-python
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
has_tablemethod was badly implemented because it didn't honour the providedschema=argument. I've updated the method and added an integration test. I also added acatalog=argument so users can runhas_tableacross catalogs in UC-land.Related Tickets & Documents
Closes #115
This change is branched off of #173 so there appears to be more happening than is necessary. You only need to review the last two commits.I rebased off ofmainso now there is a sensible number of commits.