Fix URI construction in ThriftBackend #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st for this Signed-off-by: Jessica <12jessicasmith34@gmail.com>
Signed-off-by: Jessica <12jessicasmith34@gmail.com>
NodeJSmith
requested review from
susodapop,
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
Signed-off-by: Jessica <12jessicasmith34@gmail.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
approved these changes
Jan 23, 2024
|
I've run our e2e tests for this change. Will merge once the PR checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #230
This pull request fixes the URI construction in the
ThriftBackendclass of thethrift_backend.pyfile. The current implementation does not handle the case where theserver_hostnameis provided with thehttps://prefix, resulting in duplicatehttps://in the URI. This PR addresses that issue by checking if theuristarts withhttps://and adding it if necessary.Additionally, this PR also fixes the case where the
server_hostnameis provided with a trailing backslash. The current implementation duplicates the trailing backslash in the URI, which is incorrect. This PR removes the duplicate backslash.Lastly, this PR includes unit tests to verify the correctness of the URI construction.
Changes:
ThriftBackendclass.Please review and merge this pull request.