Skip to content

Commit

Permalink
Fix deeplinks format to work across all clouds (#1044)
Browse files Browse the repository at this point in the history
Tested on native databricks, azure, gcp, and aws. 

Pipeline links seem to work fine too, as they already use "hash" links
  • Loading branch information
ilia-db authored Feb 6, 2024
1 parent 62a47e3 commit 0f85446
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class JobTreeNode implements BundleResourceExplorerTreeNode {
return undefined;
}

return `${host.toString()}jobs/${this.data.id}`;
return `${host.toString()}#job/${this.data.id}`;
}

constructor(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class TaskRunStatusTreeNode implements BundleResourceExplorerTreeNode {
return undefined;
}

return `${host.toString()}jobs/${this.jobId}/runs/${
return `${host.toString()}#job/${this.jobId}/run/${
this.runDetails.run_id
}`;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export class TaskTreeNode implements BundleResourceExplorerTreeNode {
return undefined;
}

return `${host.toString()}jobs/${this.jobId}/tasks/${this.taskKey}`;
return `${host.toString()}#job/${this.jobId}/tasks/task/${
this.taskKey
}`;
}
constructor(
private readonly context: ExtensionContext,
Expand Down

0 comments on commit 0f85446

Please sign in to comment.