Skip to content

Commit

Permalink
Pin dbconnect v2 version to 13.3.2 (#877)
Browse files Browse the repository at this point in the history
## Changes
<!-- Summary of your changes that are easy to understand -->

## Tests
<!-- How is this tested? -->
  • Loading branch information
kartikgupta-db authored Sep 27, 2023
1 parent 3594918 commit 16615b1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class DbConnectAccessVerifier extends MultiStepAccessVerifier {
try {
const exists = await this.pythonExtension.findPackageInEnvironment(
"databricks-connect",
"latest"
"13.3.2"
);
if (exists) {
return this.acceptStep("checkDbConnectInstall");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,10 @@ export class MsPythonExtensionWrapper implements Disposable {
}
}

async getPackageDetailsFromEnvironment(name: string, version?: string) {
async getPackageDetailsFromEnvironment(
name: string,
version?: string | RegExp
) {
const executable = await this.getPythonExecutable();
if (!executable) {
return undefined;
Expand All @@ -180,18 +183,19 @@ export class MsPythonExtensionWrapper implements Disposable {
return data.find(
(item) =>
item.name === name &&
(version === undefined || item.version === version)
(version === undefined ||
item.version.match(version) !== undefined)
);
}

async findPackageInEnvironment(name: string, version?: string) {
async findPackageInEnvironment(name: string, version?: string | RegExp) {
return (
(await this.getPackageDetailsFromEnvironment(name, version)) !==
undefined
);
}

async installPackageInEnvironment(name: string, version?: string) {
async installPackageInEnvironment(name: string, version?: string | RegExp) {
const executable = await this.getPythonExecutable();
if (!executable) {
throw Error("No python executable found");
Expand Down

0 comments on commit 16615b1

Please sign in to comment.