Replace JSON.stringify based object comparisions with `lodash.isEqu…

…al` (#943)

## Changes
<!-- Summary of your changes that are easy to understand -->

## Tests
<!-- How is this tested? -->

packages/databricks-vscode/package.json

@@ -704,6 +704,7 @@
         "add": "^2.0.6",
         "ansi-to-html": "^0.7.2",
         "bcryptjs": "^2.4.3",
+        "lodash": "^4.17.21",
         "triple-beam": "^1.4.1",
         "winston": "^3.10.0",
         "yaml": "^2.3.2"

packages/databricks-vscode/src/cluster/ClusterManager.ts

@@ -1,7 +1,7 @@
 import {compute, Time, TimeUnits} from "@databricks/databricks-sdk";
 import {Cluster} from "../sdk-extensions";
 import {CancellationTokenSource, Disposable} from "vscode";
-
+import _ from "lodash";
 export class ClusterManager implements Disposable {
     private cancellationTokenSource?: CancellationTokenSource;
     private refreshTimer?: NodeJS.Timer;
@@ -18,9 +18,7 @@ export class ClusterManager implements Disposable {
         this.refreshTimer = setInterval(async () => {
             const oldState = this.cluster.state;
             await this.cluster.refresh();
-            if (
-                JSON.stringify(oldState) !== JSON.stringify(this.cluster.state)
-            ) {
+            if (!_.isEqual(oldState, this.cluster.state)) {
                 this.onChange(this.cluster.state);
             }
         }, this.refreshTimeout.toMillSeconds().value);

packages/databricks-vscode/src/configuration/BundleConfigReaderWriter.ts

@@ -3,7 +3,7 @@ import {BundleFileSet, parseBundleYaml, writeBundleYaml} from "../bundle";
 import {BundleTarget} from "../bundle/types";
 import {Mutex} from "../locking";
 import {BundleConfig, ConfigReaderWriter, isBundleConfigKey} from "./types";
-
+import _ from "lodash";
 /**
  * Reads and writes bundle configs. This class does not notify when the configs change.
  * We use the BundleWatcher to notify when the configs change.
@@ -178,7 +178,8 @@ export class BundleConfigReaderWriter
         }
 
         const newTargetData = this.writerMapping[key](targetData, value);
-        if (JSON.stringify(newTargetData) === JSON.stringify(targetData)) {
+
+        if (_.isEqual(newTargetData, targetData)) {
             return;
         }
         data.targets = {...data.targets, [target]: newTargetData};

packages/databricks-vscode/src/configuration/ConfigModel.ts

@@ -13,6 +13,7 @@ import {Mutex} from "../locking";
 import {BundleWatcher} from "../bundle";
 import {CachedValue} from "../locking/CachedValue";
 import {StateStorage} from "../vscode-objs/StateStorage";
+import _ from "lodash";
 
 function isDirectToBundleConfig(
     key: keyof BundleConfig,
@@ -72,8 +73,7 @@ export class ConfigModel implements Disposable {
                 (oldValue === null && newValue[key] !== undefined) ||
                 // Old value is not null, and old and new values for the key are different
                 (oldValue !== null &&
-                    JSON.stringify(oldValue.config[key]) !==
-                        JSON.stringify(newValue[key]))
+                    !_.isEqual(oldValue.config[key], newValue[key]))
             ) {
                 this.changeEmitters.get(key)?.emitter.fire();
                 didAnyConfigChange = true;

yarn.lock

@@ -3910,6 +3910,7 @@ __metadata:
     fs-extra: ^11.1.1
     glob: ^10.3.10
     json-schema-to-typescript: ^13.1.1
+    lodash: ^4.17.21
     mocha: ^10.2.0
     mock-require: ^3.0.3
     nyc: ^15.1.0