List profiles with all auth methods (#1027)

## Changes JS SDK now supports all auth methods so we no longer have to filter out unsupported auth methods. With the bump of the SDK this PR also adds support for Databricks OAuth U2M on Azure and GCP. ## Tests Manually tests
databricks · Feb 2, 2024 · 41ca392 · 41ca392
1 parent abaa30b
commit 41ca392
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/packages/databricks-vscode/src/cli/CliWrapper.ts b/packages/databricks-vscode/src/cli/CliWrapper.ts
@@ -132,7 +132,11 @@ export class CliWrapper {
             return [];
         }
 
-        const profiles = JSON.parse(res.stdout).profiles || [];
+        let profiles = JSON.parse(res.stdout).profiles || [];
+
+        // filter out account profiles
+        profiles = profiles.filter((p: any) => !p.account_id);
+
         const result = [];
 
         for (const profile of profiles) {

diff --git a/packages/databricks-vscode/src/configuration/configureWorkspaceWizard.ts b/packages/databricks-vscode/src/configuration/configureWorkspaceWizard.ts
@@ -209,15 +209,7 @@ async function listProfiles(cliWrapper: CliWrapper) {
         }
     });
 
-    return profiles.filter((profile) => {
-        return [
-            "pat",
-            "basic",
-            "azure-cli",
-            "oauth-m2m",
-            "azure-client-secret",
-        ].includes(profile.authType);
-    });
+    return profiles;
 }
 
 async function validateDatabricksHost(
@@ -243,11 +235,11 @@ async function validateDatabricksHost(
 
 function authMethodsForHostname(host: URL): Array<AuthType> {
     if (isAzureHost(host)) {
-        return ["azure-cli", "profile"];
+        return ["databricks-cli", "azure-cli", "profile"];
     }
 
     if (isGcpHost(host)) {
-        return ["google-id", "profile"];
+        return ["databricks-cli", "google-id", "profile"];
     }
 
     if (isAwsHost(host)) {