Skip to content

Commit

Permalink
Add explicit dependency on ms jupyter extension (#814)
Browse files Browse the repository at this point in the history
## Changes

## Tests
<!-- How is this tested? -->
  • Loading branch information
kartikgupta-db authored Jul 20, 2023
1 parent db55c27 commit 86d991f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 3 additions & 2 deletions packages/databricks-vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"license": "LicenseRef-LICENSE",
"version": "1.1.0",
"engines": {
"vscode": "^1.76.0"
"vscode": "^1.78.0"
},
"categories": [
"Data Science",
Expand Down Expand Up @@ -638,7 +638,8 @@
]
},
"extensionDependencies": [
"ms-python.python"
"ms-python.python",
"ms-toolsai.jupyter"
],
"vsce": {
"dependencies": false,
Expand Down
8 changes: 6 additions & 2 deletions packages/databricks-vscode/src/test/e2e/wdio.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,17 @@ export const config: Options.Testrunner = {
for (let i = 0; i < 2; i++) {
try {
await new Promise((resolve, reject) => {
const extensionDependencies =
packageJson.extensionDependencies.flatMap((item) => [
"--install-extension",
item,
]);
execFile(
cli,
[
"--extensions-dir",
EXTENSION_DIR,
"--install-extension",
"ms-python.python",
...extensionDependencies,
"--install-extension",
VSIX_PATH,
"--force",
Expand Down

0 comments on commit 86d991f

Please sign in to comment.