-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add e2e tests for bundle init flow (#1073)
Add smoke tests for bundle init and auth flows. Also fixes these problems: - DATABRICKS_CONFIG_FILE env var was not always respected (for example when creating a new profile) - bundle file watcher was broken on windows: we were using raw fsPath with backslashes, which doesn't work for globs - saveNewProfile was broken on windows: `toISOString` returns values with characters that aren't allowed in windows paths, resulting in `ENOENT` errors from `copyFile`
- Loading branch information
Showing
22 changed files
with
698 additions
and
478 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| import path from "node:path"; | ||
| import assert from "node:assert"; | ||
| import * as fs from "fs/promises"; | ||
| import { | ||
| dismissNotifications, | ||
| waitForInput, | ||
| getViewSection, | ||
| waitForLogin, | ||
| } from "./utils.ts"; | ||
| import {CustomTreeSection} from "wdio-vscode-service"; | ||
|
|
||
| const BUNDLE = ` | ||
| bundle: | ||
| name: hello_test | ||
| targets: | ||
| dev_test: | ||
| mode: development | ||
| default: true | ||
| workspace: | ||
| host: _HOST_ | ||
| `; | ||
|
|
||
| let projectDir: string; | ||
| let bundleConfig: string; | ||
| let cfgPath: string; | ||
| let cfgContent: Buffer; | ||
|
|
||
| describe("Configure Databricks Extension", async function () { | ||
| this.timeout(3 * 60 * 1000); | ||
|
|
||
| before(async function () { | ||
| assert(process.env.WORKSPACE_PATH, "WORKSPACE_PATH doesn't exist"); | ||
| assert( | ||
| process.env.DATABRICKS_CONFIG_FILE, | ||
| "DATABRICKS_CONFIG_FILE doesn't exist" | ||
| ); | ||
| cfgPath = process.env.DATABRICKS_CONFIG_FILE; | ||
| projectDir = process.env.WORKSPACE_PATH; | ||
| bundleConfig = path.join(projectDir, "databricks.yml"); | ||
| cfgContent = await fs.readFile(cfgPath); | ||
| }); | ||
|
|
||
| after(async function () { | ||
| await fs.unlink(bundleConfig); | ||
| if (cfgContent) { | ||
| await fs.writeFile(cfgPath, cfgContent); | ||
| } | ||
| }); | ||
|
|
||
| it("should open VSCode and dismiss notifications", async function () { | ||
| const workbench = await browser.getWorkbench(); | ||
| const title = await workbench.getTitleBar().getTitle(); | ||
| assert( | ||
| title.indexOf("[Extension Development Host]") >= 0, | ||
| "Unexpected VSCode title" | ||
| ); | ||
| await dismissNotifications(); | ||
| }); | ||
|
|
||
| it("should wait for a welcome screen", async () => { | ||
| const section = await getViewSection("CONFIGURATION"); | ||
| const welcomeButtons = await browser.waitUntil(async () => { | ||
| const welcome = await section!.findWelcomeContent(); | ||
| const buttons = await welcome!.getButtons(); | ||
| if (buttons?.length >= 2) { | ||
| return buttons; | ||
| } | ||
| }); | ||
| assert(welcomeButtons, "Welcome buttons don't exist"); | ||
| const initTitle = await welcomeButtons[0].getTitle(); | ||
| const quickStartTitle = await welcomeButtons[1].getTitle(); | ||
| assert( | ||
| initTitle.toLowerCase().includes("initialize"), | ||
| "'initialize` button doesn't exist" | ||
| ); | ||
| assert( | ||
| quickStartTitle.toLowerCase().includes("quickstart"), | ||
| "'quickstart' button doesn't exist" | ||
| ); | ||
| }); | ||
|
|
||
| it("should automatically login after detecting bundle configuration", async () => { | ||
| assert(process.env.DATABRICKS_HOST, "DATABRICKS_HOST doesn't exist"); | ||
| await fs.writeFile( | ||
| bundleConfig, | ||
| BUNDLE.replace("_HOST_", process.env.DATABRICKS_HOST) | ||
| ); | ||
| await waitForLogin("DEFAULT"); | ||
| }); | ||
|
|
||
| it("should create new profile", async () => { | ||
| // We create a new profile programmatically to avoid leaking tokens through screenshots or video reporters. | ||
| // We still trigger similar code path to the UI flow. | ||
| await browser.executeWorkbench(async (vscode) => { | ||
| await vscode.commands.executeCommand( | ||
| "databricks.connection.saveNewProfile", | ||
| "NEW_PROFILE" | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| it("should change profiles", async () => { | ||
| const section = (await getViewSection( | ||
| "CONFIGURATION" | ||
| )) as CustomTreeSection; | ||
| assert(section, "CONFIGURATION section doesn't exist"); | ||
| const signInButton = await browser.waitUntil( | ||
| async () => { | ||
| const items = await section.getVisibleItems(); | ||
| for (const item of items) { | ||
| const label = await item.getLabel(); | ||
| if (label.toLowerCase().includes("auth type")) { | ||
| return item.getActionButton("Sign in"); | ||
| } | ||
| } | ||
| }, | ||
| {timeout: 10_000} | ||
| ); | ||
| assert(signInButton, "Sign In button doesn't exist"); | ||
| (await signInButton.elem).click(); | ||
|
|
||
| const authMethodInput = await waitForInput(); | ||
| const newProfilePick = | ||
| await authMethodInput.findQuickPick("NEW_PROFILE"); | ||
| assert( | ||
| newProfilePick, | ||
| "NEW_PROFILE is absent in the quick pick selection" | ||
| ); | ||
| await newProfilePick.select(); | ||
| await waitForLogin("NEW_PROFILE"); | ||
| }); | ||
|
|
||
| it("should pick up new profile after reloading", async () => { | ||
| const workbench = await driver.getWorkbench(); | ||
| const editorView = workbench.getEditorView(); | ||
| await editorView.closeAllEditors(); | ||
| await workbench.executeCommand("Developer: Reload Window"); | ||
| await waitForLogin("NEW_PROFILE"); | ||
| }); | ||
| }); |
Oops, something went wrong.