Skip to content

Commit

Permalink
State message tooltips (#1100)
Browse files Browse the repository at this point in the history
State messages can contain long errors and are frequently truncated.
By default VSCode shows labels as tooltips, which is not useful.

Also removed the empty node between workflows and pipelines.
  • Loading branch information
ilia-db authored Feb 28, 2024
1 parent ab214b4 commit f0986e1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export class JobRunStatusTreeNode implements BundleResourceExplorerTreeNode {
{
label: "State Message",
description: this.runDetails.state?.state_message,
tooltip: this.runDetails.state?.state_message,
contextValue: "state_message",
},
this
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
} from "./types";
import {ExtensionContext, TreeItemCollapsibleState} from "vscode";
import {PipelineTreeNode} from "./PipelineTreeNode";
import {TreeItemTreeNode} from "./TreeItemTreeNode";

function humaniseResourceType(type: BundleResourceExplorerTreeNode["type"]) {
switch (type) {
Expand Down Expand Up @@ -93,10 +92,6 @@ export class ResourceTypeHeaderTreeNode
);
if (pipelines.length > 0) {
roots.push(
new TreeItemTreeNode(
{collapsibleState: TreeItemCollapsibleState.None},
undefined
),
new ResourceTypeHeaderTreeNode(context, "pipelines", pipelines)
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export class TaskRunStatusTreeNode implements BundleResourceExplorerTreeNode {
{
label: "State Message",
description: this.runDetails.state?.state_message,
tooltip: this.runDetails.state?.state_message,
contextValue: "state_message",
},
this
Expand Down

0 comments on commit f0986e1

Please sign in to comment.