Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add venv or conda to gitignore before deployments #1364

Closed
wants to merge 1 commit into from
Closed

Add venv or conda to gitignore before deployments #1364

wants to merge 1 commit into from
+86 −2

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Sep 18, 2024

Changes

This only covers top level .venv or .conda environments (the only two you can create with the python extension flow that we trigger).

We ask the user permission to do that, which can be permanently ignored for a specific project

Tests

manually

@ilia-db
Copy link
Contributor Author

ilia-db commented Sep 25, 2024

Cancelling in favour of using the CLI with the new --verbose flag: https://github.com/databricks/cli/pull/1774/files

We will still need to update the CLI, and add an ability to cancel deployments

@ilia-db ilia-db closed this Sep 25, 2024
@ilia-db ilia-db deleted the ilia-db/add-venv-to-gitignore branch September 25, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikgupta-db kartikgupta-db kartikgupta-db approved these changes

@fjakobs fjakobs Awaiting requested review from fjakobs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilia-db @kartikgupta-db