Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CLI to 228.1 and regenerate schema #1369

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Bump CLI to 228.1 and regenerate schema #1369

merged 5 commits into from
Sep 25, 2024
+15,621 −6,679

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Sep 23, 2024 •
edited
Loading

Changes

CLI generates schema with additional string types added for almost complex sub types (to support complex variables).
We usually work with bundle validate or summary outputs, which have expanded variables, so we don't need to account for additional string types.

Had to resort to typescript magic to strip down strings from all union types.

Also moved to the quicktype-core dependency to generate the typescript definitions, since the previous dependency wasn't handling recursive types (and CLI now generate them).

Tests

existing tests and typechecks

@ilia-db
Bump CLI to 228.1 and generate new types
bb54ce6 
CLI changed it schema output, and now every field can also be a string
(due to variables). This breaks many usages of the schema types, since we
don't expect strings to be everywhere, as we rely not on the raw yaml config,
but on the 'bundle validate' (or 'summary') output, which extraploates variables.

Had to resort to typescript magic to strip down strings from all union types.
@ilia-db
Remove unused dependency
51c00a2
@ilia-db ilia-db changed the title Ilia db/cli 228.1 and new types Bump CLI to 228.1 and regenerate schema Sep 23, 2024
@ilia-db ilia-db merged commit 896668b into bundle-integ Sep 25, 2024
26 checks passed
@ilia-db ilia-db deleted the ilia-db/cli-228.1-and-new-types branch September 25, 2024 11:34
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
ilia-db added a commit that referenced this pull request Sep 26, 2024
@github-actions @web-flow @ilia-db
Release: v2.4.3 (#1377)
c552ff3 
## packages/databricks-vscode
##  (2024-09-25)

* Bump CLI to 228.1 and regenerate schema (#1369)
([896668b](896668b)),
closes
[#1369](#1369)
* Cancel workflow run if the webview panel is closed before the run even
started (#1365)
([d090ec7](d090ec7)),
closes
[#1365](#1365)
* DB Connect Progress: Make sure we always end up at 100% (#1363)
([e51e62b](e51e62b)),
closes
[#1363](#1363)
* Dbconnect progress (#1355)
([a9f79d2](a9f79d2)),
closes
[#1355](#1355)
* Let users cancel deploy and destroy actions (#1375)
([33602dd](33602dd)),
closes
[#1375](#1375)



## packages/databricks-vscode-types
##  (2024-09-25)

---------

Co-authored-by: releasebot <noreply@github.com>
Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjakobs fjakobs fjakobs approved these changes

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilia-db @fjakobs