-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CLI to 228.1 and regenerate schema #1369
Merged
Merged
+15,621
−6,679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI changed it schema output, and now every field can also be a string (due to variables). This breaks many usages of the schema types, since we don't expect strings to be everywhere, as we rely not on the raw yaml config, but on the 'bundle validate' (or 'summary') output, which extraploates variables. Had to resort to typescript magic to strip down strings from all union types.
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:56
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:57
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:57
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:57
— with
GitHub Actions
Failure
ilia-db
changed the title
Ilia db/cli 228.1 and new types
Bump CLI to 228.1 and regenerate schema
Sep 23, 2024
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 13:59
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:00
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:43
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:43
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:43
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
September 23, 2024 14:43
— with
GitHub Actions
Failure
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:04
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:04
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:04
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:04
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:05
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:06
— with
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
September 23, 2024 15:06
— with
GitHub Actions
Inactive
fjakobs
approved these changes
Sep 24, 2024
Merged
ilia-db
added a commit
that referenced
this pull request
Sep 26, 2024
## packages/databricks-vscode ## (2024-09-25) * Bump CLI to 228.1 and regenerate schema (#1369) ([896668b](896668b)), closes [#1369](#1369) * Cancel workflow run if the webview panel is closed before the run even started (#1365) ([d090ec7](d090ec7)), closes [#1365](#1365) * DB Connect Progress: Make sure we always end up at 100% (#1363) ([e51e62b](e51e62b)), closes [#1363](#1363) * Dbconnect progress (#1355) ([a9f79d2](a9f79d2)), closes [#1355](#1355) * Let users cancel deploy and destroy actions (#1375) ([33602dd](33602dd)), closes [#1375](#1375) ## packages/databricks-vscode-types ## (2024-09-25) --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CLI generates schema with additional string types added for almost complex sub types (to support complex variables).
We usually work with
bundle validate
orsummary
outputs, which have expanded variables, so we don't need to account for additional string types.Had to resort to typescript magic to strip down strings from all union types.
Also moved to the
quicktype-core
dependency to generate the typescript definitions, since the previous dependency wasn't handling recursive types (and CLI now generate them).Tests
existing tests and typechecks