Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve run button UX #1397

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Improve run button UX #1397

merged 3 commits into from
Oct 18, 2024

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Oct 18, 2024 •
edited
Loading

Changes

  • Add login command to the run context menu if the extension is logged out
  • Focus config view when the login command is executed
  • Fix a bug where the run button isn't visible if the vscode is opened with a python file already active
Screenshot 2024-10-18 at 11 13 24

The Sign-In item is not visible in the logged in state

Tests

Manually and existing tests

@ilia-db
Improve run button UX
02564e7 
- Add login command to the run context menu if the extension is logged out
- Focus config view when the login command is executed
- Fix a bug whe run button isn't visible if the vscode is opened with a python file already active
@ilia-db
Update context menu item groups
2cd26b7
@ilia-db ilia-db requested a review from fjakobs October 18, 2024 12:14
@ilia-db ilia-db changed the title Ilia db/run button ux Run button UX Oct 18, 2024
@ilia-db ilia-db changed the title Run button UX Improve run button UX Oct 18, 2024
fjakobs
fjakobs approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@fjakobs fjakobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This UX is much better

@ilia-db ilia-db merged commit c1c4a43 into bundle-integ Oct 18, 2024
26 checks passed
@ilia-db ilia-db deleted the ilia-db/run-button-ux branch October 18, 2024 12:47
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Merged
ilia-db added a commit that referenced this pull request Oct 24, 2024
@github-actions @web-flow @ilia-db
Release: v2.4.7 (#1408)
3e5dc49 
## packages/databricks-vscode
##  (2024-10-24)

* Add e2e tests for the deployment cancellation (#1396)
([94bf23b](94bf23b)),
closes
[#1396](#1396)
* Don't initialise spark progress widget if it's not supported (#1402)
([afe75eb](afe75eb)),
closes
[#1402](#1402)
* Fix CLI cancellation on windows (#1393)
([9c864af](9c864af)),
closes
[#1393](#1393)
* Improve environment setup UX (#1395)
([97daab1](97daab1)),
closes
[#1395](#1395)
* Improve profiles loading (#1398)
([95ab5c6](95ab5c6)),
closes
[#1398](#1398)
* Improve run button UX (#1397)
([c1c4a43](c1c4a43)),
closes
[#1397](#1397)
* Prevent welcome view flashes (#1399)
([261e06c](261e06c)),
closes
[#1399](#1399)
* Update the CLI to v0.231.0 (#1407)
([05114fa](05114fa)),
closes
[#1407](#1407)
* Use "bundle sync" instead of "bundle deploy" for remote run commands
(#1401)
([7afb87f](7afb87f)),
closes
[#1401](#1401)



## packages/databricks-vscode-types
##  (2024-10-24)

---------

Co-authored-by: releasebot <noreply@github.com>
Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjakobs fjakobs fjakobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilia-db @fjakobs