Prevent welcome view flashes #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you switch to the Databricks panel (after the extension is already logged in), you will still see "Create a new Databricks Project" welcome view for half a second. This is because our main view takes this long to load all the relevant information (sync component make API request to the workspace). This PR prevents UI flashed by setting up welcome views with additional flags.
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
fjakobs
approved these changes
Oct 21, 2024
Merged
ilia-db
added a commit
that referenced
this pull request
Oct 24, 2024
## packages/databricks-vscode ## (2024-10-24) * Add e2e tests for the deployment cancellation (#1396) ([94bf23b](94bf23b)), closes [#1396](#1396) * Don't initialise spark progress widget if it's not supported (#1402) ([afe75eb](afe75eb)), closes [#1402](#1402) * Fix CLI cancellation on windows (#1393) ([9c864af](9c864af)), closes [#1393](#1393) * Improve environment setup UX (#1395) ([97daab1](97daab1)), closes [#1395](#1395) * Improve profiles loading (#1398) ([95ab5c6](95ab5c6)), closes [#1398](#1398) * Improve run button UX (#1397) ([c1c4a43](c1c4a43)), closes [#1397](#1397) * Prevent welcome view flashes (#1399) ([261e06c](261e06c)), closes [#1399](#1399) * Update the CLI to v0.231.0 (#1407) ([05114fa](05114fa)), closes [#1407](#1407) * Use "bundle sync" instead of "bundle deploy" for remote run commands (#1401) ([7afb87f](7afb87f)), closes [#1401](#1401) ## packages/databricks-vscode-types ## (2024-10-24) --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Right now if you switch to the Databricks panel (after the extension is already logged in), you will still see "Create a new Databricks Project" welcome view for half a second.
This is because our main view takes this long to load all the relevant information (sync component make API request to the workspace). This PR prevents UI flashed by adding "Loading configuration" welcome view based on the isBundleProject flag.
Tests
Manual and existing tests