Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export DATABRICKS_HOST env var with correct protocol #841

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

kartikgupta-db
Copy link
Contributor

Changes

  • also add unit tests for env vars

Tests

  • unit
  • manual

fixes #836

@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@kartikgupta-db kartikgupta-db temporarily deployed to azure-prod-usr August 18, 2023 23:44 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #841 (7b7e3b4) into main (cfe7d15) will increase coverage by 0.22%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   79.78%   80.01%   +0.22%     
==========================================
  Files          47       47              
  Lines        1766     1766              
  Branches      366      366              
==========================================
+ Hits         1409     1413       +4     
+ Misses        356      352       -4     
  Partials        1        1              
Flag Coverage Δ
integration 62.34% <ø> (+0.28%) ⬆️
unit 66.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
js-sdk 80.01% <ø> (+0.22%) ⬆️

@kartikgupta-db kartikgupta-db enabled auto-merge (squash) August 21, 2023 11:41
@kartikgupta-db kartikgupta-db merged commit 2b62e41 into main Aug 21, 2023
1 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
kartikgupta-db added a commit that referenced this pull request Sep 11, 2023
## packages/databricks-vscode
## <small>1.1.2 (2023-09-07)</small>

* Append databricks cli path to the end of PATH (#833)
([cfe7d15](cfe7d15)),
closes
[#833](#833)
* Bump databricks cli to v0.204.0 (#861)
([b7e4909](b7e4909)),
closes
[#861](#861)
* Don't cache environment variables across restarts for a workspace
(#835)
([71e1c55](71e1c55)),
closes
[#835](#835)
* Don't import `dbutils.widget` until use (#859)
([0a9e694](0a9e694)),
closes
[#859](#859)
* Export DATABRICKS_HOST env var with correct protocol (#841)
([2b62e41](2b62e41)),
closes
[#841](#841)
[#836](#836)
* Fix `# MAGIC` commands and `restart kernels` dialog (#858)
([a5c26e3](a5c26e3)),
closes
[#858](#858)
* Move SDK into a separate repository (#838)
([58163ec](58163ec)),
closes
[#838](#838)
* Move sdk/services from the SDK to VS Code (#852)
([f544d6b](f544d6b)),
closes
[#852](#852)
* Support for %run magics and # MAGIC commands (#834)
([65ab0c2](65ab0c2)),
closes
[#834](#834)
* Traverse parent directories to find and load
.databricks/.databricks.env from notebook init script (
([7b43bd7](7b43bd7)),
closes
[#845](#845)



## packages/databricks-vscode-types
## <small>1.1.2 (2023-09-07)</small>

* Move SDK into a separate repository (#838)
([58163ec](58163ec)),
closes
[#838](#838)
* Move sdk/services from the SDK to VS Code (#852)
([f544d6b](f544d6b)),
closes
[#852](#852)

---------

Co-authored-by: releasebot <noreply@github.com>
Co-authored-by: Kartik Gupta <88345179+kartikgupta-db@users.noreply.github.com>
Co-authored-by: kartikgupta-db <kartik.gupta@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Extension exports DATABRICKS_HOST variable that dbx does not accept
3 participants