modified acceptance test

internal/acceptance/data_users_test.go

@@ -1,28 +1,54 @@
 package acceptance
 
 import (
-	"fmt"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
+const dataSourceTemplate = `
+	resource "databricks_user" "user1" {
+		user_name = "testuser1@databricks.com"
+	}
+
+	resource "databricks_user" "user2" {
+		user_name = "testuser2@databricks.com"
+	}
+
+	data "databricks_users" "this" {
+		user_name_contains = "testuser"
+	}
+`
+
+func checkUsersDataSourcePopulated(t *testing.T) func(s *terraform.State) error {
+	return func(s *terraform.State) error {
+		ds, ok := s.Modules[0].Resources["data.databricks_users.this"]
+		require.True(t, ok, "data.databricks_users.this has to be there")
+
+		usersCount := ds.Primary.Attributes["users.#"]
+		require.Equal(t, "2", usersCount, "expected two users")
+
+		userIds := []string{
+			ds.Primary.Attributes["users.0.id"],
+			ds.Primary.Attributes["users.1.id"],
+		}
+
+		expectedUserIDs := []string{
+			s.Modules[0].Resources["databricks_user.user1"].Primary.ID,
+			s.Modules[0].Resources["databricks_user.user2"].Primary.ID,
+		}
+
+		assert.ElementsMatch(t, expectedUserIDs, userIds, "expected user ids to match")
+
+		return nil
+	}
+}
+
 func TestAccDataSourceDataUsers(t *testing.T) {
 	accountLevel(t, step{
-		Template: `
-		data "databricks_users" "this" {
-			display_name_contains = "testuser"
-		}`,
-		Check: func(s *terraform.State) error {
-			r, ok := s.RootModule().Resources["data.databricks_users.this"]
-			if !ok {
-				return fmt.Errorf("data not found in state")
-			}
-			ids := r.Primary.Attributes["users.#"]
-			if ids == "" {
-				return fmt.Errorf("users is empty: %v", r.Primary.Attributes)
-			}
-			return nil
-		},
+		Template: dataSourceTemplate,
+		Check:    checkUsersDataSourcePopulated(t),
 	})
 }