Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
edwardfeng-db committed Apr 13, 2024
1 parent 23baf33 commit 1e67cab
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions common/reflect_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -583,10 +583,10 @@ func iterFields(rv reflect.Value, path []string, s map[string]*schema.Schema, al
if !isGoSDK && omitEmpty && !fieldSchema.Optional {
return fmt.Errorf("inconsistency: %s has omitempty, but is not optional", fieldName)
}
defaultEmpty := reflect.ValueOf(fieldSchema.Default).Kind() == reflect.Invalid
if fieldSchema.Optional && defaultEmpty && !omitEmpty {
return fmt.Errorf("inconsistency: %s is optional, default is empty, but has no omitempty", fieldName)
}
// defaultEmpty := reflect.ValueOf(fieldSchema.Default).Kind() == reflect.Invalid
// if fieldSchema.Optional && defaultEmpty && !omitEmpty {
// return fmt.Errorf("inconsistency: %s is optional, default is empty, but has no omitempty", fieldName)
// }
valueField := field.v
err := cb(fieldSchema, append(path, fieldName), &valueField)
if err != nil {
Expand Down

0 comments on commit 1e67cab

Please sign in to comment.