added support for primary key rely

databricks · Oct 25, 2024 · eb8f4ca · eb8f4ca
1 parent 021c206
commit eb8f4ca
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/catalog/resource_sql_table.go b/catalog/resource_sql_table.go
@@ -52,6 +52,7 @@ type SqlKeyConstraint interface {
 
 type SqlPrimaryKeyConstraint struct {
 	PrimaryKey string `json:"primary_key" tf:"alias:key,computed"`
+	Rely       bool   `json:"rely,omitempty" tf:"default:false,alias:key,computed"`
 }
 
 type SqlForeignKeyConstraint struct {
@@ -63,7 +64,11 @@ type SqlForeignKeyConstraint struct {
 }
 
 func (sqlKeyConstraint SqlPrimaryKeyConstraint) getConstraint() string {
-	return fmt.Sprintf("PRIMARY KEY (%s)", sqlKeyConstraint.PrimaryKey)
+	var constraint = fmt.Sprintf("PRIMARY KEY (%s)", sqlKeyConstraint.PrimaryKey)
+	if sqlKeyConstraint.Rely == true {
+		constraint += " RELY"
+	}
+	return constraint
 }
 
 func (sqlKeyConstraint SqlForeignKeyConstraint) getConstraint() string {

diff --git a/catalog/resource_sql_table_test.go b/catalog/resource_sql_table_test.go
@@ -88,6 +88,7 @@ func TestResourceSqlTableCreateStatement_PrimaryKeyConstraint(t *testing.T) {
 			{
 				SqlKeyConstraint: SqlPrimaryKeyConstraint{
 					PrimaryKey: "id",
+					Rely:       true,
 				},
 			},
 		},
@@ -96,7 +97,7 @@ func TestResourceSqlTableCreateStatement_PrimaryKeyConstraint(t *testing.T) {
 	assert.Contains(t, stmt, "CREATE EXTERNAL TABLE `main`.`foo`.`bar`")
 	assert.Contains(t, stmt, "USING DELTA")
 	assert.Contains(t, stmt, "(`id`  NOT NULL, `name`  NOT NULL COMMENT 'a comment')")
-	assert.Contains(t, stmt, "(PRIMARY KEY (id))")
+	assert.Contains(t, stmt, "(PRIMARY KEY (id) RELY)")
 	assert.Contains(t, stmt, "LOCATION 's3://ext-main/foo/bar1' WITH (CREDENTIAL `somecred`)")
 	assert.Contains(t, stmt, "COMMENT 'terraform managed'")
 }

diff --git a/internal/acceptance/sql_table_test.go b/internal/acceptance/sql_table_test.go
@@ -171,6 +171,7 @@ func TestUcAccResourceSqlTableWithPrimaryAndForeignKeyConstraints_Managed(t *tes
 			}
 			key_constraint {
 				primary_key = "id"
+				rely = "true"
 			}
 			key_constraint {
 				referenced_key = "external_id"
@@ -213,6 +214,7 @@ func TestUcAccResourceSqlTableWithPrimaryAndForeignKeyConstraints_Managed(t *tes
 			}
 			key_constraint {
 				primary_key = "id"
+				rely = "true"
 			}
 			key_constraint {
 				referenced_key = "external_id"