Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Automatically create parent_path folder if it doesn't exist #3778

Merged
merged 3 commits into from
Aug 22, 2024
Merged

[Feature] Automatically create parent_path folder if it doesn't exist #3778

merged 3 commits into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. [Feature] Automatically create parent_path folder if it doesn't exist 

    This makes behavior consistent with other workspace objects - notebooks, workspace files,
etc.

I have the skeleton of the test for it, but it doesn't work because I can't mock the same
API call two times with different return results
    @alexott
    alexott committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0971863 View commit details
    Browse the repository at this point in the history

  2. Add test

    @alexott
    alexott committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7926c8f View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @alexott
    alexott committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ea33957 View commit details
    Browse the repository at this point in the history