Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Make plugin framework infra functions work for Enum types #3813

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Fix] Make plugin framework infra functions work for Enum types #3813

merged 1 commit into from
Jul 24, 2024

Conversation

edwardfeng-db
Copy link
Contributor

@edwardfeng-db edwardfeng-db commented Jul 23, 2024 •
edited
Loading

Changes

  • Make the two converter functions + StructToSchema work for Enum types
  • We do not need to use types.String for Enum types as they do not have a force send zero value problem
  • Adding a unit test test case

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@edwardfeng-db edwardfeng-db requested review from a team as code owners July 23, 2024 16:46
@edwardfeng-db edwardfeng-db requested review from hectorcast-db and tanmay-db and removed request for a team July 23, 2024 16:46
@alexott
Copy link
Contributor

alexott commented Jul 24, 2024

Do we have only string enum types in SDK? Or we may have int-based enums as well?

@edwardfeng-db
Copy link
Contributor Author

@alexott Based on the codegen template I only see strings

alexott
alexott approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tanmay-db tanmay-db changed the title Make plugin framework infra functions work for Enum types [Fix] Make plugin framework infra functions work for Enum types Jul 24, 2024
@tanmay-db tanmay-db merged commit f94bd5d into terraform-plugin-framework Jul 24, 2024
4 of 10 checks passed
@tanmay-db tanmay-db deleted the edwardfeng-db/support-enums branch July 24, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@tanmay-db tanmay-db tanmay-db approved these changes

@hectorcast-db hectorcast-db Awaiting requested review from hectorcast-db hectorcast-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardfeng-db @alexott @tanmay-db