Make CustomizableSchema work for Plugin Framework #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfeng-db
requested review from
mgyucht and
tanmay-db
and removed request for
a team
tanmay-db
approved these changes
Jul 26, 2024
| func (s *CustomizableSchemaPluginFramework) SetRequired(path ...string) *CustomizableSchemaPluginFramework { | ||
| cb := func(a schema.Attribute) schema.Attribute { | ||
| switch attr := a.(type) { | ||
| case schema.SingleNestedAttribute: |
There was a problem hiding this comment.
since all types perform the same operation, it might be good if we can club them together using a common interface
| } | ||
|
|
||
| func (s *CustomizableSchemaPluginFramework) SetSensitive(path ...string) *CustomizableSchemaPluginFramework { | ||
| cb := func(a schema.Attribute) schema.Attribute { |
|
|
||
| // Helper function for navigating through schema attributes, panics if path does not exist or invalid. | ||
| func navigateSchema(s *schema.Attribute, path ...string) (schema.Attribute, error) { | ||
| cs := s |
There was a problem hiding this comment.
using descriptive variable naming might be helpful in code readability.
edwardfeng-db
merged commit 1562784
into
terraform-plugin-framework
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallydocs/folderinternal/acceptance