Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reflect_resource_plugin_framework to make acceptance test pass #3854

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Update reflect_resource_plugin_framework to make acceptance test pass #3854

merged 3 commits into from
Aug 7, 2024

Conversation

edwardfeng-db
Copy link
Contributor

@edwardfeng-db edwardfeng-db commented Aug 4, 2024 •
edited
Loading

Changes

  • Subpart of Acceptance Test Plugin Framework #3841
  • Updated reflect_resource_plugin_framework to handle cases
    • When a field in the given source struct is nil, the converter function has to be able to handle it
    • Handle enums in tfsdk structs as types.String
    • When a field does not exist on the destination struct, ignore the field
  • Added unit test for the cases mentioned above

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@edwardfeng-db edwardfeng-db requested review from a team as code owners August 4, 2024 20:27
@edwardfeng-db edwardfeng-db requested review from tanmay-db and removed request for a team August 4, 2024 20:27
tanmay-db
tanmay-db approved these changes Aug 7, 2024
View reviewed changes
common/reflect_resource_plugin_framework.go Show resolved Hide resolved
common/reflect_resource_plugin_framework.go Show resolved Hide resolved
common/reflect_resource_plugin_framework.go Outdated Show resolved Hide resolved
@edwardfeng-db edwardfeng-db merged commit 05692c9 into terraform-plugin-framework Aug 7, 2024
3 of 4 checks passed
@edwardfeng-db edwardfeng-db deleted the edwardfeng-db/update-reflect-resource branch August 7, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardfeng-db @tanmay-db