Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add databricks_alert resource to replace databricks_sql_alert #4051

Merged
merged 24 commits into from
Oct 18, 2024
Merged

[Feature] Add databricks_alert resource to replace databricks_sql_alert #4051

merged 24 commits into from
Oct 18, 2024
+698 −3

Commits on Oct 3, 2024

  1. [Feature] Add databricks_alert resource to replace `databricks_sql_… 

    …alert`

New resource use the [new Alerts API](https://docs.databricks.com/api/workspace/alerts/create)
instead of legacy one that will be deprecated. New resource has slightly different set of
parameters, so it was decided to create new resource and deprecate old one.

This resource uses old TF SDK to be compatible with TF exporter (until #4050 is implemented).
    @alexott
    alexott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    355a791 View commit details
    Browse the repository at this point in the history

  2. Started to add unit tests

    @alexott
    alexott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5910dfb View commit details
    Browse the repository at this point in the history

  3. read and delete tests

    @alexott
    alexott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    12d5984 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. finish with the unit tests

    @alexott
    alexott committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c9c9822 View commit details
    Browse the repository at this point in the history

  2. Add deprecation message to sql alert resource

    @alexott
    alexott committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1ed658e View commit details
    Browse the repository at this point in the history

  3. Added integration test

    @alexott
    alexott committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8b8e71c View commit details
    Browse the repository at this point in the history

  4. Fix integration test template

    @alexott
    alexott committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2ab3db1 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'main' into new-alert-resource

    @alexott
    alexott committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    17dd2cc View commit details
    Browse the repository at this point in the history

  2. Add suppress diff for workspace files

    @alexott
    alexott committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1a0ecf1 View commit details
    Browse the repository at this point in the history

  3. Add docs

    @alexott
    alexott committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    06bf71c View commit details
    Browse the repository at this point in the history

  4. Tune schema customization

    @alexott
    alexott committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    eabde7a View commit details
    Browse the repository at this point in the history

  5. Add setting the owner on creation

    @alexott
    alexott committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    03243fc View commit details
    Browse the repository at this point in the history

  6. Add another custom diff for parent_path

    @alexott
    alexott committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    85d0c09 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Add migration guide

    @alexott
    alexott committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f42bc9b View commit details
    Browse the repository at this point in the history

  2. Add an example to the migration guide

    @alexott
    alexott committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    81af2f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into new-alert-resource

    @alexott
    alexott committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6688eee View commit details
    Browse the repository at this point in the history

  2. Add an example of permissions for alerts

    @alexott
    alexott committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9b4fc63 View commit details
    Browse the repository at this point in the history

  3. Update docs/resources/alert.md 

    Co-authored-by: Miles Yucht <miles@databricks.com>
    @alexott @mgyucht
    alexott and mgyucht authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a6ee435 View commit details
    Browse the repository at this point in the history

  4. Start to address review comments

    @alexott
    alexott committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a9a747b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Update migration instructions for TF 1.7+

    @alexott
    alexott committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0aebe5a View commit details
    Browse the repository at this point in the history

  2. reimplement permissions test

    @alexott
    alexott committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7f3e132 View commit details
    Browse the repository at this point in the history

  3. Fix integration test

    @alexott
    alexott committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0df79b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into new-alert-resource

    @alexott
    alexott committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2b9b5e0 View commit details
    Browse the repository at this point in the history

  2. Add support for notify_on_ok field

    @alexott
    alexott committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7147e71 View commit details
    Browse the repository at this point in the history