Display username while removing the user from the group #11438

kanavnarula · 2024-09-20T03:47:24Z

This change is to display username (for the confirmation) while removing the user from the group.

Before:

After:

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

coderabbitai · 2024-09-20T03:47:43Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kanavnarula · 2024-09-20T06:40:00Z

@david-leifker - Does it make sense to keep double quotes around the username in remove group modal capture above. Please suggest.

jjoyce0510

Hi @kanavnarula!

Thanks for the contribution. In general, the idea makes sense . The following comment must be addressed before merging this one in:

We never should use the "URN" of the user to display their name, as we are doing in this PR. Instead, we should use the display name of the entity which can be obtained via entityRegistry.getDisplayName(EntityType.CorpUser, entity)

Thanks
John

kanavnarula · 2024-09-21T08:24:10Z

Hi @kanavnarula!

Thanks for the contribution. In general, the idea makes sense . The following comment must be addressed before merging this one in:

We never should use the "URN" of the user to display their name, as we are doing in this PR. Instead, we should use the display name of the entity which can be obtained via entityRegistry.getDisplayName(EntityType.CorpUser, entity)

Thanks John

Hi @jjoyce0510,

Thanks for looking in the PR. URN was coming as string to the function so could not use entityRegistry.getDisplayName(EntityType.CorpUser, entity).

I have updated the function signature to accept CorpUser entity instead of string. Please check and suggest if these changes are looking fine.

Thanks
Kanav Narula

rtekal · 2024-09-30T16:16:47Z

@jjoyce0510 When you get a chance, please review this PR. Thanks in advance.

kanavnarula · 2024-10-08T15:36:26Z

@jjoyce0510 - Did you get chance to check the PR changes.

kanavnarula · 2024-10-22T15:41:36Z

@jjoyce0510 @david-leifker - Please review when you get chance. Thanks in advance!

david-leifker

Seems like it addressed the comments. Going to merge. Thanks!

jjoyce0510 · 2024-10-22T16:49:16Z

datahub-web-react/src/app/entity/group/GroupMembers.tsx

@@ -137,12 +137,13 @@ export default function GroupMembers({ urn, pageSize, isExternalGroup, onChangeM
        }, 3000);
    };

-    const onRemoveMember = (memberUrn: string) => {
+    const onRemoveMember = (memberEntity: CorpUser) => {
+        const memberName = memberEntity?.properties?.displayName || undefined;


please use entityRegistry.getDisplayName(EntityType.CorpUser, memberEntity)

@jjoyce0510 - Logic updated to pull display name using above command. Thanks!

kanavnarula · 2024-10-24T15:46:07Z

@jjoyce0510 @david-leifker - Closing this PR as I messed up by adding other file changes related to another contribution.
New PR created - #11706

kanavnarula and others added 15 commits August 30, 2024 13:31

Advance search - Added case sensitive flag for CONTAINS

8457b94

Merge branch 'master' into master

fe84c68

Merge branch 'master' into master

7d91099

Spotless fix

c600aa5

Merge branch 'master' into master

34a8348

Merge branch 'master' into master

8181eb8

Merge branch 'master' into master

59674e8

test cases

86caccc

Merge branch 'master' into master

253b54b

Merge branch 'master' into master

21e47b2

Merge branch 'master' into master

78678a5

Merge branch 'master' into master

77a0372

Merge branch 'master' into master

5cf0d60

Merge branch 'datahub-project:master' into master

4256026

Show user name while removing user from the group

dfd0b70

github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Sep 20, 2024

Fix linting issue

042d241

vercel bot deployed to Preview September 20, 2024 04:23 View deployment

Fix prettier issue

b2107d8

vercel bot deployed to Preview September 20, 2024 06:44 View deployment

mac and others added 2 commits September 20, 2024 12:19

remove double quotes

8edeb3b

Merge branch 'master' into master

15e23e1

vercel bot deployed to Preview September 20, 2024 07:26 View deployment

Merge branch 'master' into master

e58e02e

vercel bot temporarily deployed to Preview September 20, 2024 16:47 Inactive

jjoyce0510 requested changes Sep 20, 2024

View reviewed changes

Display username instead of urn

7bc95ce

display name in place of urn

5ef48ee

vercel bot deployed to Preview September 21, 2024 08:29 View deployment

Merge branch 'master' into master

332015f

vercel bot deployed to Preview September 24, 2024 06:45 View deployment

kanavnarula requested a review from jjoyce0510 September 24, 2024 15:15

Merge branch 'master' into master

35847e7

vercel bot deployed to Preview October 22, 2024 15:54 View deployment

david-leifker approved these changes Oct 22, 2024

View reviewed changes

jjoyce0510 reviewed Oct 22, 2024

View reviewed changes

david-leifker self-requested a review October 22, 2024 16:49

kanavnarula added 2 commits October 23, 2024 11:43

Use displayName method to pull corp user name

392b35e

Merge branch 'master' into master

f77adf9

vercel bot deployed to Preview October 23, 2024 06:44 View deployment

kanavnarula and others added 3 commits October 24, 2024 20:49

Merge branch 'datahub-project:master' into master

9619e81

Add parent container hierarchy label to the container

b9af57e

Add parent container hierarchy label to the container

f2f1290

kanavnarula closed this Oct 24, 2024

vercel bot deployed to Preview October 24, 2024 16:02 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display username while removing the user from the group #11438

Display username while removing the user from the group #11438

kanavnarula commented Sep 20, 2024 •

edited

Loading

coderabbitai bot commented Sep 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

kanavnarula commented Sep 20, 2024 •

edited

Loading

jjoyce0510 left a comment

kanavnarula commented Sep 21, 2024

rtekal commented Sep 30, 2024

kanavnarula commented Oct 8, 2024

kanavnarula commented Oct 22, 2024

david-leifker left a comment

jjoyce0510 Oct 22, 2024

kanavnarula Oct 23, 2024

kanavnarula commented Oct 24, 2024

Display username while removing the user from the group #11438

Display username while removing the user from the group #11438

Conversation

kanavnarula commented Sep 20, 2024 • edited Loading

Checklist

coderabbitai bot commented Sep 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

kanavnarula commented Sep 20, 2024 • edited Loading

jjoyce0510 left a comment

Choose a reason for hiding this comment

kanavnarula commented Sep 21, 2024

rtekal commented Sep 30, 2024

kanavnarula commented Oct 8, 2024

kanavnarula commented Oct 22, 2024

david-leifker left a comment

Choose a reason for hiding this comment

jjoyce0510 Oct 22, 2024

Choose a reason for hiding this comment

kanavnarula Oct 23, 2024

Choose a reason for hiding this comment

kanavnarula commented Oct 24, 2024

kanavnarula commented Sep 20, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

kanavnarula commented Sep 20, 2024 •

edited

Loading