Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connector for Neo4j #11526

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

feat: connector for Neo4j #11526

wants to merge 33 commits into from

Conversation

k-bartlett
Copy link

@k-bartlett k-bartlett commented Oct 3, 2024 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 3, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2024 •
edited
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keith-fullsight
Merge branch 'master' into feat(ingestion/neo4j)
d4e3d1a 
# Conflicts:
#	metadata-service/war/src/main/resources/boot/data_platforms.json
mayurinehate
mayurinehate reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Will go over rest of connector code next week.

There are some conflicts on PR - can you please resolve them ? It would help if you can reset files with mere formatting(newline) changes to avoid more such conflicts.

Thanks.

metadata-ingestion/docs/sources/neo4j/neo4j.md Outdated Show resolved Hide resolved
metadata-ingestion/docs/sources/neo4j/neo4j.md Outdated Show resolved Hide resolved
metadata-ingestion/docs/sources/neo4j/neo4j.md Outdated Show resolved Hide resolved
metadata-ingestion/docs/sources/neo4j/neo4j_recipe.yml Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/neo4j/neo4j_source.py Show resolved Hide resolved
asikowitz and others added 9 commits October 21, 2024 12:21
@asikowitz @keith-fullsight
feat(ingest/transformer/domain): Add support for on conflict do nothi…
3153e6a 
…ng to dataset domain transformers (datahub-project#11649)
@feldjay @keith-fullsight
fix(ingest/looker): Remove bad imports from looker_common (datahub-pr…
20aa223 
…oject#11663)
@hsheth2 @mayurinehate @keith-fullsight
feat(ingest/looker): include project name in model/explore properties (…
c4a8001 
…datahub-project#11664)

Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
@hsheth2 @keith-fullsight
feat(ingest/fivetran): protect against high sync volume (datahub-proj…
12abda4 
…ect#11589)
@shirshanka @keith-fullsight
feat(sdk):platform-resource - complex queries (datahub-project#11675)
bda79bd
@deepgarg-visa @keith-fullsight
fix(docs): fix businessattributes doc (datahub-project#11653)
03c9de6
@hsheth2 @keith-fullsight
feat(ingest/fivetran): add safeguards on table/column lineage (datahu…
9b82a7b 
…b-project#11674)
@Masterchen09 @shirshanka @keith-fullsight
fix(ui): show DataHub logo for DataHub sources in ingestion souces li…
ed7c368 
…st (datahub-project#11658)

Co-authored-by: Shirshanka Das <shirshanka@apache.org>
@k-bartlett
Merge branch 'master' into feat(ingestion/neo4j)
44fad3a
@keith-fullsight
Merge remote-tracking branch 'origin/master'
ef7390a 
# Conflicts:
#	metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py
#	metadata-ingestion/src/datahub/ingestion/source/fivetran/fivetran_log_api.py
#	metadata-ingestion/src/datahub/ingestion/source/fivetran/fivetran_query.py
@keith-fullsight
Merge remote-tracking branch 'datahub_fork/feat(ingestion/neo4j)' int…
c0e667d 
…o feat(ingestion/neo4j)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@k-bartlett @mayurinehate @keith-fullsight @asikowitz @feldjay @hsheth2 @shirshanka @deepgarg-visa @Masterchen09