Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ingest): streamline CLL generation #11645

Merged
merged 7 commits into from
Oct 18, 2024
Merged

perf(ingest): streamline CLL generation #11645

merged 7 commits into from
Oct 18, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 16, 2024

Bump dep + reduce the set of optimizer rules we run for CLL. This should reduce memory requirements and improve parsing speeds.

Stacked on #11635

Likely will help with #11147 and #11597, but is not a full solve.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 16, 2024
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

@hsheth2 hsheth2 changed the title feat(ingest): simplify CLL generation perf(ingest): simplify CLL generation Oct 16, 2024
@hsheth2 hsheth2 changed the title perf(ingest): simplify CLL generation perf(ingest): streamline CLL generation Oct 17, 2024
@treff7es
Copy link
Contributor

@hsheth2 there is a mypy linter issue

@hsheth2 hsheth2 merged commit 6e3724b into master Oct 18, 2024
71 of 73 checks passed
@hsheth2 hsheth2 deleted the sqlglot-bump branch October 18, 2024 00:51
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Oct 21, 2024
epatotski pushed a commit to acryldata/datahub that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants