fix(ingest): run sqllineage in process by default #11650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure what the root cause here was, but it seems like our usage of multiprocessing was causing the main thread to hang on exit. Because we have test order randomization enabled for unit tests, it happened inconsistently and I used
--random-order-seed=598371
to reproduce it - it required a specific order of tests to be run. Additionally, this bug would only manifest on Linux, which is why my attempts to repro the issue on mac did not work.Main changes:
ThreadedIteratorExecutor
instead of multiprocessingsql_parser
config option from lookml, since it was no longer supported.Checklist